r #1410
Open
r #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update precompiled lib tests, for the new cache logic.
This expands on emscripten-core#460 which added a file in each install dir with the version, that lets us know not to re-download it. That didn't integrate with is_installed, so it wasn't reported properly, which this PR fixes. With this we can remove a hack for python, as we can simply not install anything if it's already installed (see line 1859). Also add the "INSTALLED" indicators on the main listings in "emsdk list". Bug was reported in emscripten-core#477
Also accept -h for help. This is the usual behaviour of most utils that accept --help. Also, now an empty call to ./emsdk does not print the full help, as discussed in emscripten-core#509.
This is part of a wider plan to remove the use of the user's HOME directory completely: emscripten-core/emscripten#9543
Split version to integers but avoid exceptions in case there is a
non-numerical character in some version.
Comparison:
Before | After
1.39.9 1.39.16
1.39.8 1.39.15
1.39.7 1.39.14
1.39.6 1.39.13
1.39.5 1.39.12
1.39.4 1.39.11
1.39.3 1.39.10
1.39.2 1.39.9
1.39.16 1.39.8
1.39.15 1.39.7
1.39.14 1.39.6
1.39.13 1.39.5
1.39.12 1.39.4
1.39.11 1.39.3
1.39.10 1.39.2
1.39.1 1.39.1
1.39.0 1.39.0
1.38.48 1.38.48
1.38.47 1.38.47
1.38.46 1.38.46
1.38.45 1.38.45
1.38.44 1.38.44
1.38.43 1.38.43
1.38.42 1.38.42
1.38.41 1.38.41
1.38.40 1.38.40
1.38.39 1.38.39
1.38.38 1.38.38
1.38.37 1.38.37
1.38.36 1.38.36
1.38.35 1.38.35
1.38.34 1.38.34
1.38.33 1.38.33
Without --network host It's impossible to build images
emscripten-core#513) Signed-off-by: Squareys <[email protected]>
We only publish on tag, but we want to build and test the image on all PRs.
- `--embeddded` mode is the now the default - embedded cache and ports is also the default - emsdk now fully polulates the cache by default so no need to do that. - always "activate" the SDK avoiding that need things to work without that. - avoid making extra symlinks. - remove python2
This was only ever set to true if the user knew to pass an undocumented extra argument called "perm".
It includes an update to v8 7.8
Remove the optional argument to contruct_env. It simple if we always construct the env in the same place. Avoid using temp files, and avoid changing directory.
…e#544) This is an alternative fix for emscripten-core/emscripten#9090 which recently came up again after emscripten-core#539. Tested with bash, tcsh and fish.
…ripten-core#546) Rename write_set_env_bat to write_set_env_script.
…ten-core#549) On platforms with no supported binary SDKs to download, find_sdk can return None which caused a check in the "list" command to fail. Checking for the return value before making method calls fixes this, and allows Linux/ARM64 to run "emsdk list" and then build an SDK from source. Fixes emscripten-core#548
This is a because its not possible to determine the location of as script that is currently being sources under a POSIX shell such as dash (the default ubuntu shell). Only bash has this special BASH_SCRIPT variable.
* Fix support for Apple M1. Node.js will still run via Rosetta 2 emulation since they do not yet have M1 support, but Python, LLVM, Emscripten and Binaryen will be native. * Update M1 python version and URL * Remove .gitignore additions * Move python first in the manifest (emscripten-core#441) * Use macosx-version-min when building python * Update Intel macOS python package name
* Remove absl from wasm_binary * Formatting fixes * Blank line, too * Reorder imports
It was still using the old repo location which was moved to the emscripten-core organization.
* Add support for ccache. * Simplify ccache activation. * Fix macOS ccache build * Make ccache executable * Add Ninja build support. Change ccache name to git. * Fix merge conflict
* allow the bazel toolchain to output html files * allow for cc_binary rule names to end in .js * fix python name * continue to call emcc instead of em++ for now * small cleanup Co-authored-by: Mitch Foley <[email protected]>
This was set back in commit cea44f4 Fixes emscripten-core#760
…SH (emscripten-core#767) Previously this had to be emsdk install sdk-releases-upstream-HASH The only thing preventing using just the hash was that there was no default for the backend, so defaulting to upstream fixes this. And then we can do emsdk install HASH
* Makes provided bazel rules look up @emsdk workspace instead of local workspace * Uses system-specific emscripten binaries instead of defaulting to linux * Provides macros for loading emsdk dependencies (nodejs and emscripten binaries) * Unhardcodes paths in bazel rules and .sh wrappers * `update_bazel_workspace.sh` now updates `revisions.bzl` * `emscripten_deps()` can be fed with specific emscripten version * Adds external usage test Addresses emscripten-core#650 and emscripten-core#696
* Update bazel/README.md * Add deps instantiation to readme * Add bazelrc explanations to readme * Note the preferred way of using bazel emsdk
… should reuse system temp directory instead, that is what it is there for. (emscripten-core#791)
This avoid polluting the global environment which makes side-by-side installational of different emscripten version harder. See emscripten-core/emscripten#13954
… dev packages as well. (emscripten-core#793)
* Add option --override-repository to allow controlling where git clones happen from. * Address review
…ten-core#801) When we deactivate a tool we also want to remove its environment variables. One driver for this is that modern sdks don't set `EM_CACHE` whereas old ones did and we want to make sure that `EM_CACHE` gets unset when folks upgrade (and then re-set if they downgrade). See emscripten-core#797.
…n-core#806) This works regardless of the name of the primary branch so that the code will continue to work if/when we rename `main` to `master`. See: emscripten-core#805
…already seem to install google-closure-compiler-windows at least. (emscripten-core#803)
…-core#805 (emscripten-core#823) See emscripten-core#805 The behavior is now: $ ./emsdk install 2.0.0 **** Error: You appear to be using the `master` branch of emsdk. We recently made the switch to using `main` In order to continue to receive updates you will need to make the switch locally too. For normal clones without any local branches simply running the following command should be enough: `git checkout main` For more information see emscripten-core#805 **** $ echo $? 1 If you see this error, you are using master, and should switch to main, which is where development now occurs.
|
Was this opened by mistake? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r