-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-136771: Added new DrumPicker component #542
base: develop
Are you sure you want to change the base?
Conversation
# Conflicts: # internal/Picker/Picker.js
OK then, LGTM :) |
We expected POC, but you've spent a lot of time because you implemented it all. Anyway, I checked the functions, not code. |
…re/PLAT-136771
# Conflicts: # samples/sampler/stories/default/Picker.js # samples/sampler/stories/default/RangePicker.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean up this PR and revisit when we need to support in the Agate
I set request changes just in case click the merge accidentally.
Thanks for your hard work. This work will defiantly worth
Checklist
Issue Resolved / Feature Added
UX design for picker components required a drum/wheel behavior of picker components
Resolution
wrap
is true, the value can be changed from last to first only via 5-way, for the momentAdditional Considerations
Links
PLAT-136771
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian [email protected]