Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-19494: css-loader v7 migration #788

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented May 24, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

css-loader v7 migration
https://github.com/webpack-contrib/css-loader/releases/tag/v7.0.0

Resolution

Change import style

// Before
import style from "./style.css";

//After
import * as style from "./style.css";

Additional Considerations

  • Those changes should be descripted on migration guide, if decided to merge.
  • Those changes should be synced with tools including css-loader v7(cli, storybook-utils)

Links

WRQ-19494

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

@hong6316 hong6316 deleted the branch develop May 30, 2024 05:43
@hong6316 hong6316 closed this May 30, 2024
hong6316 and others added 2 commits June 4, 2024 09:04
* updated storybook to version 8.1.5

* Fixed custom toolbars for acent, hightlight and default skin styles

* code review fixes

* removed parasite div

* code review fixes

* eslint fixes

* removed unneeded storybook ui props

* updated storybook to 8.1.6 and storybook-tils branch to enact_v5

* removed docs configuration and docs information in About story
@hong6316 hong6316 reopened this Jun 19, 2024
@hong6316 hong6316 changed the base branch from feature/node18 to feature/enact_v5 June 19, 2024 12:32
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (a711565) to head (a711565).

Current head a711565 differs from pull request most recent head 202b764

Please upload reports for the commit 202b764 to get more accurate results.

Additional details and impacted files
@@                Coverage Diff                @@
##           feature/enact_v5     #788   +/-   ##
=================================================
  Coverage             85.13%   85.13%           
=================================================
  Files                   120      120           
  Lines                  4507     4507           
  Branches               1237     1237           
=================================================
  Hits                   3837     3837           
  Misses                  523      523           
  Partials                147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feature/enact_v5 to develop July 25, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants