Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Safer cell sizing option #2795

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Djspaceg
Copy link
Member

Checklist

  • I have read and understand the contribution guide

  • A CHANGELOG entry is included

  • At least one test case is included for this feature or bug fix

  • Documentation was added or is not needed

  • This is an API breaking change

Issue Resolved / Feature Added

Cell doesn't allow for an option that shrinks to the size of the content, but stops at the boundary for the Layout.

Resolution

Cell now supports a size="content" option which does exactly that. The layout is allowed to flex in height while the cell fits the available space without going over.

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #2795 into develop will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2795      +/-   ##
===========================================
- Coverage    44.62%   44.62%   -0.01%     
===========================================
  Files          163      163              
  Lines         8199     8200       +1     
  Branches      2000     2001       +1     
===========================================
  Hits          3659     3659              
- Misses        3408     3409       +1     
  Partials      1132     1132              
Impacted Files Coverage Δ
packages/ui/Layout/Layout.js 94.44% <ø> (ø)
packages/ui/Layout/Cell.js 94.44% <87.50%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402e11b...88d9640. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants