WRP-21128: Fixed components used in enact/ui/Layout/Cell which cannot have their css customized in consumer apps. #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3162 +/- ##
===========================================
- Coverage 82.36% 82.31% -0.05%
===========================================
Files 155 156 +1
Lines 7207 7211 +4
Branches 1907 1908 +1
===========================================
Hits 5936 5936
- Misses 999 1002 +3
- Partials 272 273 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Daniel Stoian <[email protected]>
daniel-stoian-lgp
changed the title
daniel-stoian-lgp
approved these changes
Jul 19, 2023
0x64
reviewed
Mar 15, 2024
- improved description of added feature inside CHANGELOG - changed documentation of added code to clarify how it works
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
0x64
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Alexandru Morariu [email protected]
Checklist
Issue Resolved / Feature Added
While working on Agate-Apps we noticed that components used in enact/ui/Layout/Cell cannot have their css customized. In order to customize it we passed the component as a child to Cell instead of using the component prop. Now we can pass the css directly.
Resolution
I added the componentCss prop to Cell component in order to increase customisation.
Additional Considerations
Links
WRP-21128
Comments