Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-3732: Notify focus moving by key from pointer mode internally #3191

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Nov 30, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

When focus is entering to or leaving from a container by 5-way key input on 5-way mode, Spotlight notify this situation internally so that related features works properly. But there is no notification on pointer mode at the same situation.

Resolution

Update internal logic to notify the situation on pointer mode just like on 5-way mode.

Additional Considerations

Links

WRQ-3732

Comments

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6becfeb) 82.22% compared to head (4533dbe) 82.16%.
Report is 1 commits behind head on develop.

Files Patch % Lines
packages/spotlight/src/spotlight.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3191      +/-   ##
===========================================
- Coverage    82.22%   82.16%   -0.06%     
===========================================
  Files          155      155              
  Lines         7149     7154       +5     
  Branches      1885     1885              
===========================================
  Hits          5878     5878              
- Misses         998     1003       +5     
  Partials       273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant