Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-19494: css-loader v7 migration #3241

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented May 24, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

css-loader v7 migration
https://github.com/webpack-contrib/css-loader/releases/tag/v7.0.0

Resolution

Change import style

// Before
import style from "./style.css";

//After
import * as style from "./style.css";

Additional Considerations

  • Those changes should be descripted on migration guide, if decided to merge.
  • Those changes should be synced with tools including css-loader v7(cli, storybook-utils)

Links

WRQ-19494

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (2777e54) to head (b8451f9).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/enact_v5    #3241      +/-   ##
====================================================
- Coverage             82.51%   82.40%   -0.12%     
====================================================
  Files                   157      157              
  Lines                  7245     7245              
  Branches               1917     1917              
====================================================
- Hits                   5978     5970       -8     
- Misses                  995     1003       +8     
  Partials                272      272              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hong6316 hong6316 deleted the branch develop May 30, 2024 05:42
@hong6316 hong6316 closed this May 30, 2024
hong6316 and others added 3 commits June 4, 2024 09:05
* Updated storybook to version 8

* upgraded storybook to 8.1.5

* minor fix for changelog

* merged with enact_v5

* Update CHANGELOG.md

* code review fixes

* revert of commented properties

* code review fix

* eslint fixes

* eslint fixes

* removed unneeded storybook ui properties

* updated storybook to 8.1.6 and storybook-utils branch to enact_v5

* removed docs configuration in preview.js
removed docs information in About story

* removed @storybook/addon-docs

* added back storybook/addon-docs
@hong6316 hong6316 reopened this Jun 19, 2024
@hong6316 hong6316 changed the base branch from feature/node18 to feature/enact_v5 June 19, 2024 10:29
hong6316 and others added 9 commits June 19, 2024 19:41
* added custom site icon for storybook

* Update packages/sampler/.storybook/manager-head.html

* removed manager-head
… utils for `marqueeDirection` (#3237)

* update marqueeDirection to use @enact/i18n API

* update CHANGELOG.md

* Update MarqueeDecorator.js

* update CHANGELOG.md

* update packages/ui/CHANGELOG.md

* remove unused module and sort modules alphabetically
Base automatically changed from feature/enact_v5 to develop July 25, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants