WRP-4076:Button: add missing @mixes tag for TooltipDecorator #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButtonDecorator is composed with TooltipDecorator, but @mixes tag for TooltipDecorator is missing in the document. Add @mixes tags for TooltipDecorator. Enact-DCO-1.0-Signed-off-by: Hoeun Ryu <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1419 +/- ##
========================================
Coverage 79.24% 79.24%
========================================
Files 136 136
Lines 6380 6380
Branches 1886 1886
========================================
Hits 5056 5056
Misses 1008 1008
Partials 316 316
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Currently, TooltipDecorator is missing from includes for ButtonDecorator description on enactjs.com.
ButtonDecorator is composed of TooltipDecorator, but @mixes tag for TooltipDecorator is missing in the documentation.
Resolution
Add @mixes tag for TooptipDecorator.
Additional Considerations
Links
WRP-4076
enactjs/agate#735
Comments
Enact-DCO-1.0-Signed-off-by: Hoeun Ryu [email protected]