Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fleetctl: {load|unload|start|stop} and get unit code cleanups #5

Closed
wants to merge 14 commits into from
Closed

fleetctl: {load|unload|start|stop} and get unit code cleanups #5

wants to merge 14 commits into from

Commits on Feb 17, 2016

  1. fleetctl: add tryWaitForUnitStates() and getBlockAttempts() 

    * tryWaitForUnitStates() tries to wait for units to reach the desired state.
* getBlockAttempts() gets the correct value of how many attempts to try
		     before giving up on an operation.

These helpers will be used to make the code more consistent and clean.
We do not intended to change any behaviour here.

---
    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    75b6088 View commit details
    Browse the repository at this point in the history

  2. load: Use the new tryWaitForUnitStates() and getBlockAttempts()

    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    ea24c8c View commit details
    Browse the repository at this point in the history

  3. start: Use the new tryWaitForUnitStates() and getBlockAttempts()

    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    62d5b6a View commit details
    Browse the repository at this point in the history

  4. stop: Use the new tryWaitForUnitStates() and getBlockAttempts()

    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    2e90705 View commit details
    Browse the repository at this point in the history

  5. unload: Use the new tryWaitForUnitStates() and getBlockAttempts()

    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    411940e View commit details
    Browse the repository at this point in the history

  6. fleetctl: move logic that lookus up a unit from a template into its o… 

    …wn function
    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    d7787d0 View commit details
    Browse the repository at this point in the history

  7. fleetctl: more cleaning and consolidate the logic to get a Unit from … 

    …disk or the Registry
    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    49344ff View commit details
    Browse the repository at this point in the history

  8. fleetctl: add debug messages arround getUnit*() functions 

    * Cover code path of getUnit*() functions with debug messages
* Improve code comments
    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    4f7fca8 View commit details
    Browse the repository at this point in the history

  9. fleetctl: remove dead code comment

    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    de05a8d View commit details
    Browse the repository at this point in the history

  10. fleetctl: inline getBlockAttempts() in tryWaitForUnitStates() calls

    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    58369b6 View commit details
    Browse the repository at this point in the history

  11. fleetctl: improve code comment about getUnitFileFromTemplate() 

    Improve code comments about getUnitFileFromTemplate() and kill some
other useless code comments.
    Djalal Harouni committed Feb 17, 2016
    Configuration menu
    Copy the full SHA
    bc091fd View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2016

  1. fleetctl: fix debug message in getUnitFile()

    Djalal Harouni committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    8cfb73b View commit details
    Browse the repository at this point in the history

  2. fleetctl: getBlockAttempts() standarise on negative meaning do not block

    Djalal Harouni committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    9ba11af View commit details
    Browse the repository at this point in the history

  3. fleetctl:test: push tests for getBlockAttempts()

    Djalal Harouni committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    75dcaa0 View commit details
    Browse the repository at this point in the history