-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endoflife api/v1 #2080
base: master
Are you sure you want to change the base?
Endoflife api/v1 #2080
Conversation
Few notes:
|
Wrote up a quick draft for the specification: endoflife-date/releases.json#1 |
5e0f74c
to
f8e238b
Compare
I modified the plugin to use a generator. The script itself is much more simple, but the corresponding template will be a bit complex (like the |
Which redirects ? The redirects based on |
The v1 redirects. |
Ok, that can wait if we decide to give time to migrate to client's maintainers. |
f8e238b
to
a471521
Compare
@captn3m0, what is your opinion about those subjects :
|
a471521
to
451c337
Compare
a301630
to
aa324fd
Compare
@captn3m0 I have worked on the API v1, here is where I am :
There are still a lot of things to do but it's going well so far. |
Don't like using |
By introducing the |
@captn3m0, another test, with a a new schema : https://deploy-preview-2080--endoflife-date.netlify.app/api/v1/android/info.json. Just toying a little bit, this is in no way a proposal. But let me know what you think of the ideas.
I am also wondering about the |
Think we can, we have Netlify header support. It's hacky, but if we set permalinks for these files correctly, and set content-type headers (application/json) from Netlify _headers file, it should work. |
1e35540
to
d6438df
Compare
Just tried in with
I tried to also redirect
|
Would it be possible to update this branch to pick up some of the latest versions? PS I also wholeheartedly support having this PR reviewed and merged @captn3m0 🙂 |
4d2ea74
to
1d44f32
Compare
1d44f32
to
9b9a9c5
Compare
9b9a9c5
to
8db47f6
Compare
8db47f6
to
c553096
Compare
c553096
to
2d329ea
Compare
hi! was this API v1 deployed? |
2d329ea
to
e61e47f
Compare
Yes, the preview is deployed on https://deploy-preview-2080--endoflife-date.netlify.app/docs/api/v1/. |
Hi! Thanks, |
Hello all |
None on my side. I am still waiting for some reviews (at least one from @captn3m0). I would like the payloads format and field names to be confirmed before merging this, because once it's released we won't be able to change it easily. |
e61e47f
to
4e54596
Compare
@captn3m0 do you think it will be merged soon? this API call adds some information which can be very useful for other tools :) |
4e54596
to
c45f548
Compare
@marcwrobel Could you please rebase this branch and update the preview API when you have time? |
Is there a planned date to release the new version of API? A preview of Swagger is available? |
This is a major rework of the API with a lot of breaking changes. See CHANGELOG_API.md for more information. Note that we thought of disabling API generation in development (using JEKYLL_ENV like the Jekyll Feed plugin - see https://github.com/jekyll/jekyll-feed/blob/master/lib/jekyll-feed/generator.rb#L145), but it was finally reverted. It does not work well with Netlify preview, and generate production URL (i.e. https://endoflife.date URLs) in development which makes it difficult to use.
c45f548
to
956a069
Compare
Done.
Nope, still waiting for some reviews.
Yes, through the preview URL : https://deploy-preview-2080--endoflife-date.netlify.app/docs/api/v1/. |
can you please elaborate where are you getting the "purl" field? |
This is a major rework of the API that fixes a lots of issues, but introduces a lot of breaking changes. See https://github.com/endoflife-date/endoflife.date/blob/2062-expose-product-info-api/CHANGELOG_API.md for more information.
Note that I thought of disabling API generation in development (using JEKYLL_ENV like the Jekyll Feed plugin - see https://github.com/jekyll/jekyll-feed/blob/master/lib/jekyll-feed/generator.rb#L145), but I finally reverted it. It does not work well with Netlify preview, and generate production URL (i.e. https://endoflife.date/ URLs) in development which makes testing more difficult.