Skip to content

Commit

Permalink
Set fail-fast to false in daily CI
Browse files Browse the repository at this point in the history
Currently in our daily, if a job fails, it will cancel the other jobs
in the same matrix, we want to avoid this so that all jobs in a matrix
can eventually run to completion.

Docs: jobs.<job_id>.strategy.fail-fast applies to the entire matrix.
If jobs.<job_id>.strategy.fail-fast is set to true or its expression
evaluates to true, GitHub will cancel all in-progress and queued jobs
in the matrix if any job in the matrix fails. This property defaults
to true.

Signed-off-by: Binbin <[email protected]>
  • Loading branch information
enjoy-binbin committed Oct 14, 2024
1 parent 1a5c80f commit 4eeca93
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@ jobs:
!contains(github.event.inputs.skipjobs, 'sanitizer')
timeout-minutes: 14400
strategy:
fail-fast: false
matrix:
compiler: [gcc, clang]
env:
Expand Down Expand Up @@ -659,6 +660,7 @@ jobs:
!contains(github.event.inputs.skipjobs, 'sanitizer')
timeout-minutes: 14400
strategy:
fail-fast: false
matrix:
compiler: [gcc, clang]
env:
Expand Down Expand Up @@ -1001,6 +1003,7 @@ jobs:

build-macos:
strategy:
fail-fast: false
matrix:
os: [macos-12, macos-14]
runs-on: ${{ matrix.os }}
Expand Down

0 comments on commit 4eeca93

Please sign in to comment.