litex_setup.py: Disable auto-update of litex_setup for CI #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new config option to litex_setup (--disable-auto-update) to disable the auto-update mechanism. It further changes the CI flow to use that flag. Why? The auto-update is a problem for the CI workflow because it will override any (especially branch-specific) changes to the litex_setup script. Then CI is testing the wrong litex_setup script.
|
<3<3 |
|
Hi and thanks @cklarhorst, this is in fact the intend of |
|
@enjoy-digital |
|
Indeed, there is now a CI detection to avoid this with #1782. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new config option to litex_setup (--disable-auto-update) to disable the auto-update mechanism. It further changes the CI flow to use that flag.
Why? The auto-update is a problem for the CI workflow because it will override any (especially branch-specific) changes to the litex_setup script. Then CI is testing the wrong litex_setup script.
This should fix the CI flow for #1776