Dts schema compliance #1973
Dts schema compliance #1973
Conversation
Adds clocks for a downstream iclink soc, for example when builder.add_json() has imported soc clocks. Node names are as per devicetree fixed-clock.yaml bindings.
This is also relevant to vexriscv_smp, not rocket specific. Fixes these dt-schema validation errors: cpus: cpu@0: 'tlb-split' is a dependency of 'd-tlb-size' from schema : http://devicetree.org/schemas/cpus.yaml# cpus: cpu@0: 'tlb-split' is a dependency of 'd-tlb-sets' from schema : http://devicetree.org/schemas/cpus.yaml# cpus: cpu@0: 'tlb-split' is a dependency of 'i-tlb-size' from schema : http://devicetree.org/schemas/cpus.yaml# cpus: cpu@0: 'tlb-split' is a dependency of 'i-tlb-sets' from schema : http://devicetree.org/schemas/cpus.yaml#
Fixes these dt-schema validation errors: /: 'compatible' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml# /: 'model' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml#
There was a problem hiding this comment.
Thanks @AndrewD, this looks fine. I'll do at least a minor adjustment (move adding the identifier constant to add_identifier method) and we'll also test the updated generated .dts on the LiteX HW CI.
|
@enjoy-digital with the change in cc1a37e this line probably needs to change to platform_name too: litex_json2dts_linux.py#L58 Related to #1960 |
The ci failure is because I used a python 3.10 feature in the type hints. Can we bump the minimum python version, or is there a desire to maintain support for 3.9? |
|
If possible, it would be nice to not use python 3.10 specific features for now. We could bump the requirement, but that's maybe not the right time. |
Would pushing a rebase that addresses this help? It looks minor. |
|
If you can just provide the change, I could integrate. |
This fixes several linux schema validation issues. Closes #1905, see #1960
This branch is on top of the branch for #1972 but that is not a dependency.