Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux dts: add vexii clint support #1983

Merged
merged 3 commits into from
Jun 11, 2024
Merged

linux dts: add vexii clint support #1983

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0b0d8d
linux dts: add vexii clint support
Dolu1990 Jun 10, 2024
87ae5db
linux dts: add vexii clint support
Dolu1990 Jun 10, 2024
8c80a6c
linux dts: rework "rocket" in cpu_name into cpu_name == "rocket"
Dolu1990 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion litex/tools/litex_json2dts_linux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def generate_dts(d, initrd_start=None, initrd_size=None, initrd=None, root_devic

# Interrupt Controller -------------------------------------------------------------------------

if (cpu_arch == "riscv") and ("rocket" in cpu_name):
if (cpu_arch == "riscv") and ("rocket" in cpu_name or "vexiiriscv" in cpu_name):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using:

if (cpu_arch == "riscv") and (cpu_name in ["rocket",  vexiiriscv"]):

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was afraid of breaking some weird stuff as :
"rocket" in cpu_name isn't equivalent to cpu_name in ["rocket"]
As there may eventualy be a "rocket_on the moon" as cpu_name ?

So i prefered not disrupting the old behaviour. As they could have done it with cpu_name == "rocket" but didn't XD

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense but cpu_name is used with cpu_architecture so if there is a "rocket_somewhere" a keyError will be produces. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed as you proposed just now ^^

# FIXME : L4 definitiion?
# CHECKME: interrupts-extended.
dts += """
Expand Down
Loading