Skip to content

Commit

Permalink
fix: fixed broken runtime since v1.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
ennioVisco committed Feb 15, 2024
1 parent 3d26491 commit 85a2243
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
java-version: 21
distribution: adopt
- name: Build documentation
run: ./gradlew dokkaHtml
run: ./gradlew dokkaHtml --no-configuration-cache
- name: Add sample test page
run: mv sample.html build/dokka/sample.html
- name: Publish documentation
Expand Down
18 changes: 13 additions & 5 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,18 @@ fun runtimeArgs(exec: Any) {
listOf(
GARBAGE_COLLECTOR,
// ENABLE_PREVIEW,
// "--add-exports", "javafx.graphics/com.sun.glass.ui=ALL-UNNAMED",
// "--add-exports", "javafx.graphics/com.sun.glass.utils=ALL-UNNAMED",
// "--add-opens", "javafx.graphics/com.sun.glass.ui=ALL-UNNAMED",
// "--add-opens", "javafx.graphics/com.sun.glass.utils=ALL-UNNAMED"
"--add-exports",
"javafx.graphics/com.sun.glass.ui=ALL-UNNAMED",
"--add-exports",
"javafx.graphics/com.sun.glass.utils=ALL-UNNAMED",
"--add-exports",
"javafx.graphics/com.sun.javafx.util=ALL-UNNAMED",
"--add-exports",
"javafx.base/com.sun.javafx.logging=ALL-UNNAMED",
"--add-opens",
"javafx.graphics/com.sun.glass.ui=ALL-UNNAMED",
"--add-opens",
"javafx.graphics/com.sun.glass.utils=ALL-UNNAMED"
)
when (exec) {
is JavaExec -> exec.jvmArgs(arguments)
Expand Down Expand Up @@ -221,7 +229,7 @@ application {
applicationDefaultJvmArgs = listOf(ENABLE_PREVIEW)
// println("Current exec dir: $executableDir")
mainClass.set(pkg("Main"))
mainModule.set("org.enniovisco.webmonitor")
// mainModule.set("com.enniovisco.webmonitor") // TODO: investigate, this seems to brake javafx deps
}

val jarsDir: Provider<Directory> = layout.buildDirectory.dir("jars")
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Kotlin config
kotlin.code.style=official
kotlin.experimental.tryK2=true
#kotlin.experimental.tryK2=true
# Gradle config
org.gradle.caching=true
org.gradle.configuration-cache=true
#org.gradle.configuration-cache=true
org.gradle.warning-mode=all
# Project info
project.name=webmonitor
Expand Down
10 changes: 9 additions & 1 deletion src/main/kotlin/module-info.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
module webmonitor {
module com.enniovisco.webmonitor {
// JavaFX
requires javafx.base;
requires javafx.controls;
requires javafx.swing;
requires javafx.graphics;
requires javafx.web;

requires org.seleniumhq.selenium.api;
Expand All @@ -16,6 +17,13 @@
requires java.scripting;

exports com.enniovisco;
exports com.enniovisco.checking;
exports com.enniovisco.cli;
exports com.enniovisco.dsl;
exports com.enniovisco.reporting;
exports com.enniovisco.space;
exports com.enniovisco.tracking;
exports com.enniovisco.tracking.commands;

opens com.enniovisco to javafx.graphics;
}

0 comments on commit 85a2243

Please sign in to comment.