Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom class to attendees URLs #1

Closed
wants to merge 1 commit into from

Conversation

enricobattocchi
Copy link
Owner

Adds a custom class, based on the question name, to URL fields when listing the attendees.
This mimics what happens for other questions where a class tix-<question-name> is added, allowing for further styling. Currently URLs only get the same, generic classes making it very difficult to style them according to their nature.

Fixes WordPress#1379

How to test the changes in this Pull Request:

  1. Create a ticket, adding 2 or more URL questions with different names (e.g. "WP.org profile", "Mastodon profile URL", etc.)
  2. Register a new attendee, answering to the URL questions above and making sure to answer 'Yes' to 'Do you want to be listed on the public Attendees page? '
  3. Visit the Attendees page and check that the URL fields, besides the default tix-field and tix-attendee-url, now have a custom class based on the related question, e.g. tix-wp-org-profile.

This mimics what happens for other questions where a class `tix-question-name` is added, allowing for further styling.
Currently URLs only get the same, generic classes making it very difficult to style them according to their nature.
Copy link

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be worth calling it tix-field-{post_name} but other than that, this seems like a safe choice and would've helped me in the past.

@enricobattocchi
Copy link
Owner Author

I wonder if it would be worth calling it tix-field-{post_name} but other than that, this seems like a safe choice and would've helped me in the past.

It would make sense, but it would break the pattern of the other questions

@enricobattocchi
Copy link
Owner Author

🤦‍♂️ somehow I didn't create the PR on the original repo but in my own fork. Closing this in favor of this other one

@enricobattocchi enricobattocchi deleted the enricobattocchi-patch-1 branch September 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attendees list: make URLs stylable based on the related question
2 participants