Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure ipfs gateway #538

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Links/ContentHashLink.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const ContentHashLink = ({ value, contentType }) => {
return <DecodedError>{error}</DecodedError>
}
if (protocolType === 'ipfs') {
externalLink = `https://gateway.ipfs.io/ipfs/${decoded}`
externalLink = `https://${decoded}.ipfs.dweb.link` // using ipfs's secured origin gateway
Copy link

@lidel lidel Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
externalLink = `https://${decoded}.ipfs.dweb.link` // using ipfs's secured origin gateway
externalLink = `https://dweb.link/ipfs/${decoded}` // using ipfs's secured origin gateway

@makoto
We recommend keeping the path-based router for improved compatibility.
go-ipfs 0.5+ will redirect to correct subdomain, and go-ipfs 0.7+ will even convert CID to DNS-compatible encoding, if the default is too long (eg. if ED25519 key is used in IPNS it will use Base36 to fit in a single DNS label)

url = `ipfs://${decoded}`
} else if (protocolType === 'bzz') {
externalLink = `https://swarm-gateways.net/bzz://${decoded}`
Expand Down