Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More perf tests #49

Merged
merged 2 commits into from
Oct 7, 2024
Merged

More perf tests #49

merged 2 commits into from
Oct 7, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 4, 2024

  • Add performance tests for realistic Sieve iterations
  • Add performance tests against glass-pumpkin

glass-pumpkin uses more MR tests than required by BPSW, so in the performance tests I used custom method to mimic that behavior. The results (against crypto-bigint=0.6.0-rc.2):

1024 bits:

  • crypto-primes default: 29ms
  • crypto-primes, matched with glass-pumpkin: 39ms
  • glass-pumpkin: 46ms

1024 bits, safe prime:

  • crypto-primes default: 1.33s
  • crypto-primes, matched with glass-pumpkin: 1.4s
  • glass-pumpkin: 1.43s

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.33%. Comparing base (08c0e5f) to head (258d153).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files           9        9           
  Lines        1344     1344           
=======================================
  Hits         1335     1335           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only complaint is about naming.

benches/bench.rs Show resolved Hide resolved
benches/bench.rs Outdated Show resolved Hide resolved
benches/bench.rs Outdated Show resolved Hide resolved
benches/bench.rs Outdated Show resolved Hide resolved
@andrewwhitehead
Copy link

Looks like another 10-15% improvement with the crypto-bigint master. I see a few places (in the Lucas test) that might benefit from a Monty::double method.

@dvdplm dvdplm merged commit eb89fca into entropyxyz:master Oct 7, 2024
12 checks passed
@fjarri fjarri deleted the more-perf-tests branch October 19, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants