Handle order events #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysseng
reviewed
Feb 21, 2024
|
|
||
| export default { | ||
| async compress(encoder: { buffer: Buffer }) { | ||
| return lz4.encode(encoder.buffer) |
There was a problem hiding this comment.
Kanskje vi kan få noen til å skru på lz4 i f.eks dev og se om dette funker? Sånn for sikkerhetsskyld. Men ikke kritisk for å merge
tysseng
reviewed
Feb 21, 2024
| import { removeEventNameLevelFromEvent } from './utils.js' | ||
|
|
||
| const isForSelfService = (eventContents: any): boolean => { | ||
| const pos = eventContents.meta?.pos |
There was a problem hiding this comment.
Hvis dette er en fast plassering for pos så kan vi kanskje trekke det ut i utils (siden tilnærmet samme kode finnes i paymentEventHandler)?
tysseng
reviewed
Feb 21, 2024
| return | ||
| } | ||
|
|
||
| const eventContents = removeEventNameLevelFromEvent(event) |
There was a problem hiding this comment.
Regner med at du har sjekket om denne er nødvendig?
tysseng
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Har lagt til støtte for order-events fra Kafka. Dersom vi får inn en order-event av typen OrderConfirmed, publiseres denne på GCP Pub/Sub.