refactor(converters): V5 no longer returns empty object on undefined …

…columns. Improved readability
entur · Jul 10, 2023 · ea0b73f · ea0b73f
1 parent 6a1d7f1
commit ea0b73f
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/next-tavla/src/Shared/utils/converters.ts b/next-tavla/src/Shared/utils/converters.ts
@@ -26,19 +26,15 @@ export function V5(setting: ReturnType<typeof V4>) {
     return {
         ...setting,
         tiles: setting.tiles.map((tile) => {
-            if (!tile.columns) return { ...tile, columns: {} }
+            const { columns: oldColumns, ...rest } = tile
+            if (!oldColumns || !oldColumns.length) return rest
 
-            const oldColumns = tile.columns
-            type TBaseColumnExtended =
-                | (typeof oldColumns)[number]['type']
-                | 'via'
-                | 'situations'
+            type TBaseColumnExtended = TBaseColumn | 'via' | 'situations'
 
-            const newColumns: Partial<Record<TBaseColumnExtended, boolean>> = {}
-
-            oldColumns.forEach((col) => {
-                newColumns[col.type] = true
-            })
+            const newColumns: Partial<Record<TBaseColumnExtended, boolean>> =
+                oldColumns.reduce((prev, next) => {
+                    return { ...prev, [next.type]: true }
+                }, {})
 
             return {
                 ...tile,