build: disable guard dog #2582
Closed
build: disable guard dog #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JP Simard <[email protected]>
|
Closing as stale now that we've migrated to the Envoy repo: https://github.com/envoyproxy/envoy/blob/main/mobile/README.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: build: disable guard dog
Additional Description: Which Envoy Mobile should never enable, because terminating the Envoy process would mean terminating the host iOS or Android app. See #2581 for more details.
Risk Level: Low, compile-time flag, no-op by default.
Testing: Building Envoy Mobile locally.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: Will be disabled when building Envoy Mobile.
Fixes: #2581
Signed-off-by: JP Simard [email protected]