Allow disabling the guard dog #23316
Conversation
Which Envoy Mobile should never enable, because terminating the Envoy process would mean terminating the host iOS or Android app. Signed-off-by: JP Simard <[email protected]>
|
As discussed in today's Envoy Mobile community call. /cc @alyssawilk @RyanTheOptimist Thanks @Reflejo for flagging this. |
|
Testing in Envoy Mobile: # Before
$ ./bazelw build --config=ios //examples/swift/async_await:app
$ nm Payload/app.app/app | grep GuardDogImpl | wc -l
641
# After
$ ./bazelw build --config=ios //examples/swift/async_await:app
$ nm Payload/app.app/app | grep GuardDogImpl | wc -l
0 |
Signed-off-by: JP Simard <[email protected]>
|
Hmmm, I think the watch dog is currently responsible for actually running the main dispatch loop, so to disable it I'll actually need to run the main dispatch loop some other way. I've marked this PR as being a draft until I can do that. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Commit Message: Allow disabling the guard dog
Additional Description: Which Envoy Mobile should never enable, because terminating the Envoy process would mean terminating the host iOS or Android app. See envoyproxy/envoy-mobile#2581 for more details.
Risk Level: Low, compile-time flag, no-op by default.
Testing: Building Envoy Mobile locally.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: Will be disabled when building Envoy Mobile.
Fixes: envoyproxy/envoy-mobile#2581
Signed-off-by: JP Simard [email protected]