Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add PR comment and cc reviewers #2280

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Dec 7, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

We tried a couple of ways to auto request reviews from @envoyproxy/gateway-reviewers, but it failed, and I tried it too today, failed again.

So current way is to add a welcome comment to cc @envoyproxy/gateway-maintainers and @envoyproxy/gateway-reviewers, they should get the ping too.

@Xunzhuo Xunzhuo requested a review from a team as a code owner December 7, 2023 09:27
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Dec 7, 2023

demo uestcer/community#191

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52af65e) 64.38% compared to head (009c2d1) 64.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
- Coverage   64.38%   64.37%   -0.02%     
==========================================
  Files         112      112              
  Lines       15874    15874              
==========================================
- Hits        10221    10219       -2     
- Misses       5004     5005       +1     
- Partials      649      650       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor

zirain commented Dec 7, 2023

I have no objection to this, but not sure this's good to go, @envoyproxy/gateway-maintainers PTAL.

@shawnh2
Copy link
Contributor

shawnh2 commented Dec 7, 2023

i think the comment is quiet long, how about shrinking down to, for example, like:


🚀 Thank you for contributing to the Envoy Gateway project! 🚀

Before merging, please ensure to follow the process below:

  1. Requesting Reviews:
  • cc @envoyproxy/gateway-reviewers team for an initial review.
  • After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review.
  1. Review Approval:
  • Your PR needs to receive at least two approvals.
  • At least one approval must come from a member of the gateway-maintainers team.
What's more, you can help expedite the processing of your PR by
  • Ensuring you have self-reviewed your work according to the project's Contribution Guidelines.
  • If your PR addresses a specific issue, make sure to mention it in the PR description.
  • Respond promptly if there are any test failures or suggestions for improvements that we comment on.

@zirain
Copy link
Contributor

zirain commented Dec 7, 2023

BTW, if you really want to add this, please mention that don't use force push like envoy does for better review.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Dec 8, 2023

@shawnh2 I like the idea.

BTW, if you really want to add this, please mention that don't use force push like envoy does for better review.

sure @zirain

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Dec 8, 2023

Signed-off-by: bitliu <[email protected]>
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: bitliu <[email protected]>
@Xunzhuo Xunzhuo changed the title feat: welcome comment and auto cc gateway reviewers ci: add PR comment and cc reviewers Dec 8, 2023
@zirain zirain merged commit 557591e into envoyproxy:main Dec 8, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants