Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enyo) InputHeader: it needs to add exception from 'Input' pre-fix #2958

Open
wants to merge 1 commit into
base: release-2.6.4-rc.18
Choose a base branch
from

Conversation

Sangwook-Lee
Copy link

Issue

InputHeader is cut off because Input height was changed.

Fix

InputHeader shouldn't be applied changed height from Input.
So, I added hegiht: inherit; to Header.less to maintain original height size.

ENYO-4862 (Enyo) InputHeader: it needs to add exception from 'Input' pre-fix
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee [email protected]

InputHeader shouldn't be applied changed height from Input.
So, I added hegiht: inherit; to Header.less to maintain original height size.

ENYO-4862 (Enyo) InputHeader: it needs to add exception from 'Input' pre-fix
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee [email protected]
@Djspaceg
Copy link
Contributor

I can't make a reliable estimate of what height: inherit will do on an <input> field within a non-statically sized element. :\ This will need to be tested to verify the consequences. The consequences should be localizable to the single component though. Just make sure that it doesn't alter the height of Header with titleBelow and subTitleBelow present.

@Sangwook-Lee
Copy link
Author

Sangwook-Lee commented Oct 31, 2017

@Djspaceg Thanks for review. We can test it in http://10.186.120.63/~sangwook/InputHeaderSample/dist/.
I think it'd be better to apply 'height' in input.less file except for 'input-header class' if that's possible. Is there any better solutions?

@Djspaceg
Copy link
Contributor

Djspaceg commented Nov 9, 2017

I'd need more information or testing to provide alternative ideas.

@Sangwook-Lee
Copy link
Author

@Djspaceg ,

Or, I think we can set "height" and "line-height" when parent is NOT "headerInput".

Input.less
&:not(.moon-input-header-input-decorator) > .moon-input { line-height: 57px; height: 57px; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants