-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to be able to run using a leap dev-install package. #355
Closed
Closed
Changes from 10 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
1a73eb8
Update tests to be able to run using a leap dev-install package.
oschwaldp-oci 13fe485
Merge branch 'main' into update-tests-to-use-leap-dev-install
oschwaldp-oci 6076d9e
Merge branch 'main' into update-tests-to-use-leap-dev-install
oschwaldp-oci 2f3cdba
Merge branch 'main' into update-tests-to-use-leap-dev-install
oschwaldp-oci d3f9b04
Add leap integration test to contract CICD workflow.
oschwaldp-oci 4995c16
Add install web3 to workflow.
oschwaldp-oci 0e9d95c
Put leap integration test into own job in workflow.
oschwaldp-oci 7f7d855
Revert back to CDT v3.1.0 for leap integration test
oschwaldp-oci 8340a29
Try setting the PYTHONPATH
oschwaldp-oci 33f27a4
Fix python path to installed leap-dev modules.
oschwaldp-oci ba3bf65
See where leap-dev is being installed.
oschwaldp-oci 4c3ac5f
Endeavor to fix the python path to TestHarness.
oschwaldp-oci aafc9a2
Debugging lack of symlink during install.
oschwaldp-oci f1c2b10
Revert back to installing using apt-get.
oschwaldp-oci f107499
Walk web3 back to a potentially more stable version.
oschwaldp-oci 80ecdf8
Fix pip install version selection.
oschwaldp-oci 8bdd860
Working through dependency issues.
oschwaldp-oci 36acfe3
Sudo to gain permissions to create the symlink.
oschwaldp-oci 7e02722
Remove PYTHONPATH now that symlink is created.
oschwaldp-oci 2f65d15
Set test environment variables.
oschwaldp-oci a16a4c2
Revert "Set test environment variables."
oschwaldp-oci 836fe14
Leap integration test workflow updates.
oschwaldp-oci c18a1f4
Workflow updates.
oschwaldp-oci 16aa944
Fix syntax.
oschwaldp-oci eb484fa
Elevate permissions.
oschwaldp-oci 8acaca5
Make logs checking steps always run even on failure.
oschwaldp-oci d8f5ec8
Build eos-evm-node step.
oschwaldp-oci 43dbf43
Upload test logs when test fails.
oschwaldp-oci 7b6a1ee
check the genesis file.
oschwaldp-oci d2b49ab
Run with verbose output.
oschwaldp-oci 12d4576
Make root directory for testing to collect all artifacts.
oschwaldp-oci 166bf93
Increase eos-evm-node verbosity for debugging workflow in cicd.
oschwaldp-oci 78e28c6
Debug where the test logs directory is.
oschwaldp-oci 534fd66
Give eos-evm-node longer to spin up and sync.
oschwaldp-oci 0cb41ad
Allow waiting and retrying row validation with eos-evm-node for slowe…
oschwaldp-oci ad13c15
Trying to debug log upload.
oschwaldp-oci 7f679fe
Increase sleep time for syncing.
oschwaldp-oci 02079ac
Troubleshooting eos evm node not spinning up in time and whether slee…
oschwaldp-oci f2c09a7
Now that uploading all logs, don't need these steps.
oschwaldp-oci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did something change? afaik all this should be installed in
/usr
when built in CIhttps://github.com/AntelopeIO/leap/blob/main/.github/workflows/build_base.yaml#L80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I'm endeavoring to figure out. I just did build using the
pinned_build.sh
script and then installed thelead-dev
pkg it created from thev4.0.4
tag. Usingdpkg -L leap-dev
it appeared thatTestHarness
was installed in/usr/local/lib/python3/dist-packages/TestHarness
. But it still isn't finding the module there either. Or rather, it is a symlink to/usr/local/share/leap_testing/tests/TestHarness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,
pinned_build.sh
does/usr/local
by default (but not in CI where it's also/usr
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. Updated the location where it installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to
export PYTHONPATH
in this case, where the test in leap doesn't need to?https://github.com/AntelopeIO/leap/blob/main/.github/workflows/build.yaml#L98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to chase that down. My current theory is that the symlink isn't being created to put the
TestHarness
into thepython3/dist-packages
. This build is runningcmake version 3.26.4
. Not sure which version is being used over in theleap
workflow since there is a switch in https://github.com/AntelopeIO/leap/blob/78c1b62a76b37ac3531e526b8434c1ce54a451c2/CMakeLists.txt#L252There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dpkg -L leap-dev | grep TestHarness
in this workflow is not showing the symlink:https://github.com/eosnetworkfoundation/eos-evm/actions/runs/5613879938/job/15210866007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although local build (note: using
pinned_build.sh
to createleap-dev
) withcmake version 3.22.1
does:So from that perspective it doesn't look like a cmake version problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where:
/usr/local/lib/python3/dist-packages/TestHarness -> ../../../share/leap_testing/tests/TestHarness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that this is due to the
postinst
script relying onCMAKE_INSTALL_FULL_LIBDIR
inv4.0.4
which sets the path for the symlink incorrectly to:ln -s ../../../share/leap_testing/tests/TestHarness /usr/lib/x86_64-linux-gnu/python3/dist-packages/TestHarness
.This has been fixed in
main
: https://github.com/AntelopeIO/leap/blob/main/scripts/postinstThus, currently setting the
PYTHONPATH
is a workaround to allow discovery of the installed python modules fromleap-dev