-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] add get transaction & get transaction receipt from rpc test #231
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
654ef31
Merge pull request #221 from eosnetworkfoundation/kayan_diff_gas_toke…
taokayan d3dd534
Merge pull request #225 from eosnetworkfoundation/elmato/merge-bump_1…
elmato dd1af24
Merge branch 'main' into elmato/merge-block-extra-data-to-main
elmato 3d78379
Merge pull request #226 from eosnetworkfoundation/elmato/merge-block-…
elmato 26a88c2
Merge branch 'main' into elmato/merge-bump_1_0_0-rc2-to-main
elmato 51e7c05
Merge pull request #227 from eosnetworkfoundation/elmato/merge-bump_1…
elmato 888b23f
add get transaction via rpc
taokayan df8ee35
add hash check, get transaction receipt
taokayan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens here if transaction does not exists?
Maybe we can assert that : signed_trx.hash == evm_tx hash
We should also call eth_getTransactionReceipt and do something similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the PR should start with
[1.0] ...
and targetrelease/1.0