-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eosio.erc2o contract implementation #5
Conversation
Make sure tests work with other token symbol names other than USDT (and also other precisions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs more tests with different symbol names and precisions (including greater precision for ERC20 than native token). As well as testing the various limits on amounts that are being enforced in the code.
Also:
|
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests are still light and even those need to be fixed. See my comment from #5 (review). The only issue is can you do any of these tests without bringing in the actual EOS EVM Contract. If so, that's more of an integration test which is tracked by #12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to call bridgereg() somewhere
and record the receiver in the table. receiver should be part of the unique key as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sol contracts needs some modification.
Resolves #612, based on @yarkinwho 's work.
list of actions:
example commands: