Support for Goéland and SC-TPTP #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file to use my fork of it. Support annotations in the tptp package, support extracting inferences and parameters for proof steps. Reconstruct Hypothesis now, rest should be straightforward.
…actic. Update documentation and manual. Some improvements can still be done (support for equality, axioms...)
sankalpgambhir
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Should we keep generated proofs on the main repository? (opinion)
There was a problem hiding this comment.
I see this relies on the Goeland files. Should this be moved to src/test/scala and also run on the CI?
| case Success(value) => proof.ValidProofTactic(bot, value.steps, Seq()) | ||
| case Failure(e) => e match | ||
| case e: FileNotFoundException => throw new Exception("For compatibility reasons, external provers can't be called in non-draft mode" + | ||
| " and all proofs must have already been generated and be available in static files. You can enable draft mode by adding `draft()` at the top of your workingfile.") |
There was a problem hiding this comment.
Suggested change
| " and all proofs must have already been generated and be available in static files. You can enable draft mode by adding `draft()` at the top of your workingfile.") | |
| " and all proofs must have already been generated and be available in static files. You can enable draft mode by adding `draft()` at the top of your working file.") |
|
|
||
| /** | ||
| * Solve a sequent using the Goéland automated theorem prover, and return the kernel proof. | ||
| * At the moment, this option is only available on Linux system. |
There was a problem hiding this comment.
Suggested change
| * At the moment, this option is only available on Linux system. | |
| * At the moment, this option is only available on Linux systems. |
| else if OS.contains("win") then | ||
| Failure(OsNotSupportedException("The Goeland automated theorem prover is not yet supported on Windows.")) | ||
| else | ||
| Failure(OsNotSupportedException("The Goeland automated theorem prover is for now only supported on Linux.")) |
There was a problem hiding this comment.
Suggested change
| Failure(OsNotSupportedException("The Goeland automated theorem prover is for now only supported on Linux.")) | |
| Failure(OsNotSupportedException("The Goeland automated theorem prover is only supported on Linux for now.")) |
There was a problem hiding this comment.
Question: Is the proof parser not part of the customTstpParser dependency?
|
One more thing: we should probably not keep the Goeland executable on the top level of the project. I propose making a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Goéland as a proof tactic, and for parsing of proofs in SC-TPTP format.