Remove redundant given Library
leading to compilation error under Scala 3.6
#224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes compilation of project when using Scala 3.6 or later due to change in givens prioritization. The issue was found by the Scala 3 Open Community Build.
Related change in the compiler scala/scala3#19300
New rule stats that:
Since Scala 3.5.0 (or under -source:3.5) compiler yields warnings:
The difference in the resolution between
and
makes a big difference in function using path-dependent types, eg
def foo()(using lib: Library, proof: lib.Proof)
. When resolved asgiven Library
we're having someLibrary
instance, whileLibrary.this.type
is requiring exact dependant value.The issue can be solved by removing redundant
given Library
Fixing this issue would allow Open CB to test this project against the newer version of the compiler.