-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- feat: update google fonts to material symbols #4085
base: develop
Are you sure you want to change the base?
Conversation
@@ -105,8 +105,7 @@ export default defineNuxtConfig({ | |||
'Source+Code+Pro': { | |||
wght: [400], | |||
}, | |||
'Material+Icons': true, | |||
'Material+Icons+Outlined': true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick check with docs, look fine
@@ -41,7 +41,7 @@ export const addVuesticToVue3App = async () => { | |||
let htmlSource = await readFile(htmlPath, 'utf-8') | |||
htmlSource = insertHead(htmlSource, [ | |||
`<link href="https://fonts.googleapis.com/css2?family=Source+Code+Pro&family=Source+Sans+Pro:wght@400;700&display=swap" rel="stylesheet">`, | |||
`<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">` | |||
`<link href="https://fonts.googleapis.com/icon?family=Material+Symbols+Outlined" rel="stylesheet">` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update IconsConfig to use material-symbols but default, instead of material icons.
I expect updating nuxt module in my project and all icons still work, even if the're symbols now.
Right now, creating new vuestic project will install Material Symbols, but we use material-icons in IconsConfig...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should release both projects simultaneously then.
Replaced Please check to make sure I haven't replaced icons where I shouldn't have, or if there are places where we still need |
I think we don't need Material Icons anymore anywhere. We just need to make sure we use symbols everywhere. The next release is gonna be 1.9.0 where we can introduce breaking changes. |
Close #3848
Types of changes