Pre-release cleanup #649
Merged
Pre-release cleanup #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
previously approved these changes
May 2, 2024
Co-authored-by: James Azam <[email protected]>
Co-authored-by: James Azam <[email protected]>
jamesmbaazam
approved these changes
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
approved these changes
May 2, 2024
jamesmbaazam
previously approved these changes
May 2, 2024
Co-authored-by: James Azam <[email protected]>
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* deprecate adjust-functions * indicate check functions are stable * mark deprecated functions as internal * make more functions internal * move init_cumulative_fit to deprecated.R * move fit functions to fit.R * update lifecycle badges * remove explicit references to 2.0.0 * completely remove update_list * line spacing * update importFrom tags * remove prior_weight * hard deprecate old truncation options * make more get_ functions internal * categorise internal functions in pkgdown * order NEWS items * add news item * re-render documentation * remove package qualifier * add PR number * make sure all examples run * remove package qualifier on internal function * Apply suggestions from code review Co-authored-by: James Azam <[email protected]> * clarify wording in _pkgdown.yml Co-authored-by: James Azam <[email protected]> * simplify internal function listing in pkgdown Co-authored-by: James Azam <[email protected]> --------- Co-authored-by: James Azam <[email protected]>
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* deprecate adjust-functions * indicate check functions are stable * mark deprecated functions as internal * make more functions internal * move init_cumulative_fit to deprecated.R * move fit functions to fit.R * update lifecycle badges * remove explicit references to 2.0.0 * completely remove update_list * line spacing * update importFrom tags * remove prior_weight * hard deprecate old truncation options * make more get_ functions internal * categorise internal functions in pkgdown * order NEWS items * add news item * re-render documentation * remove package qualifier * add PR number * make sure all examples run * remove package qualifier on internal function * Apply suggestions from code review Co-authored-by: James Azam <[email protected]> * clarify wording in _pkgdown.yml Co-authored-by: James Azam <[email protected]> * simplify internal function listing in pkgdown Co-authored-by: James Azam <[email protected]> --------- Co-authored-by: James Azam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #593.
Closes #598.
Conducts some general clean-up as can be seen in the individual commits.
Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request