-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
913: Functions for PIT histograms #949
Open
sbfnk
wants to merge
10
commits into
main
Choose a base branch
from
pit-histogram
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikosbosse
reviewed
Oct 20, 2024
quantiles <- seq(0, 1, 1 / num_bins) | ||
} | ||
## avoid rounding errors | ||
quantiles <- round(quantiles, 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to round twice? (we round in line 187 as well)
Nice, thank you! Broader thoughts/questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #913.
It adds
plot_histogram_sample()
andget_pit_histogram()
functions and implements the nonrandomised PIT for count data suggested by Czado et al.It also removes
get_pit()
andpit_sample()
- I don't think calculating PIT values themselves is very interesting or something anyone would ever want to do but if people disagree we could keep them in.It also removes
plot_pit()
. Now that densities of the histogram can be obtained directly I would think that a user will be able to make their own plot.Checklist
lintr::lint_package()
to check for style issues introduced by my changes.