Update metalgateway operator and patch requestBody schemas of create APIs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ualNetworkCreateInput, also updated VlanHelper
…s, update metalgatewayoperator
displague
reviewed
Sep 22, 2022
displague
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
I've applied these changes upstream:
- remove project_id from VRFCreateInput and VirtualNetworkCreateInput
- rename MetalGatewayInput to MetalGatewayCreateInput
The expansion of VrfCreateInput in createVrf is not present upstream - this is an artifact of stitching. I'll see if we can remedy that in the stitching process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues:
#46
#45
#44