fix: update module outputs to match what they were before v0.3.0 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Privitere <[email protected]>
Signed-off-by: Chris Privitere <[email protected]>
ctreatma
commented
Apr 9, 2024
ctreatma
commented
Apr 9, 2024
| } | ||
|
|
||
| output "fabric_connection_speed" { | ||
| description = "Connection speed." | ||
| value = module.equinix-fabric-connection.primary_connection.speed |
There was a problem hiding this comment.
Speed is always in Mbps for Fabric connection resources, so removed the speed_unit output and updated the speed output description to note the unit
displague
approved these changes
Apr 10, 2024
|
How does this PR relate to #13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.3.0 of this module, we upgraded from the old ECX-v3-based terraform-equinix-fabric-connection to the new Fabric-v4-based module. The Fabric terraform resources are not drop-in replacements for ECX, so the upgrade introduced an unnoticed error in this module's outputs.
This updates the module outputs to reference the correct attributes in the new Fabric resources and to remove outputs that are no longer available due to changes in the resources and/or the underlying API.