Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move device resource and datasource to separate package #707

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ctreatma
Copy link
Contributor

This moves the device resource and data sources out of the equinix package and into an isolated directory & package to align with #106.

@ctreatma ctreatma requested review from a team as code owners June 21, 2024 21:47
@ctreatma ctreatma requested a deployment to internal June 24, 2024 16:21 — with GitHub Actions Abandoned
displague
displague previously approved these changes Jul 10, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.95238% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.89%. Comparing base (f8c2ab9) to head (d698e10).
Report is 9 commits behind head on main.

Files Patch % Lines
internal/resources/metal/device/resource.go 84.09% 6 Missing and 1 partial ⚠️
internal/resources/metal/device/datasource.go 83.87% 4 Missing and 1 partial ⚠️
internal/resources/metal/device/sweeper.go 0.00% 3 Missing ⚠️
internal/resources/metal/device/helpers.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #707       +/-   ##
===========================================
+ Coverage   34.44%   51.89%   +17.45%     
===========================================
  Files         151      152        +1     
  Lines       20710    20922      +212     
===========================================
+ Hits         7133    10857     +3724     
+ Misses      13415     9630     -3785     
- Partials      162      435      +273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@displague displague merged commit 3dda81d into main Sep 25, 2024
6 of 7 checks passed
@displague displague deleted the metal-device-package branch September 25, 2024 21:04
Copy link

This PR is included in version 2.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants