Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds teardown to avoid flaky tests with run_dialog #9149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds teardown to avoid flaky tests with run_dialog #9149

wants to merge 1 commit into from
+4 −3

Conversation

AugustoMagalhaes
Copy link
Contributor

@AugustoMagalhaes AugustoMagalhaes commented Nov 5, 2024 •
edited by eivindjahren
Loading

Issue
Resolves #9144

Approach
Modifies run_dialog fixture to yield instead of return run_dialog and closes it after each test.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:flaky-test-fix PR fixes a flaky test label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
None yet
Milestone
No milestone
2 participants
@AugustoMagalhaes @eivindjahren