Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Approach
Implementing router-dealer pattern with custom acknowledgments with zmq
Server / router (ensemble evaluator) gets messages and keeps track of connected clients wherein in additional it sends
ack
message to dispachers to confirm that the message has been received .Dealer(s) = clients and dispatchers are sending messages to the router via:
which essentially batching multiple messages into one.
dispatcher now send messages in chunks
dispatcher always for acknolwedgment from the evaluator
removing websockets, no more wait_for_evaluator
Settup encryption with curve
each dealer (client, dispatcher) will get a unique name
PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable