Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform validation earlier by returning EnOptConfig instead of dict #9249

Merged

Conversation

StephanDeHoop
Copy link
Contributor

@StephanDeHoop StephanDeHoop commented Nov 18, 2024

Issue
Resolves #9155

Approach
When converting EverestConfig into EnOptConfig, return actual EnOptConfig instead of dictionary to perform the validation of the configuration earlier. Still have to do some re-factoring but will discuss with Pieter what he had in mind. After discussing with Pieter: do refactoring in a different PR.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@StephanDeHoop StephanDeHoop added everest release-notes:skip If there should be no mention of this in release notes labels Nov 18, 2024
@StephanDeHoop StephanDeHoop marked this pull request as ready for review November 19, 2024 08:46
@StephanDeHoop StephanDeHoop merged commit f38fd9d into equinor:main Nov 19, 2024
42 checks passed
@StephanDeHoop StephanDeHoop deleted the use_enoptconfig_instead_of_dict branch November 19, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
everest release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create EnoptConfig instead of a dict when configuring the optimization
2 participants