FIX: Review feedback

src/fmu/dataio/providers/_fmu.py

@@ -206,6 +206,7 @@ def _get_runpath_from_env() -> Path | None:
 
     @staticmethod
     def _get_ert_meta() -> fields.Ert:
+        """Constructs the `Ert` Pydantic object for the `ert` metadata field."""
         try:
             sim_mode = ErtSimulationMode(FmuEnv.SIMULATION_MODE.value)
         except ValueError:

tests/data/snakeoil/export-a-surface

@@ -10,10 +10,10 @@ from fmu.config import utilities as ut
 
 
 def main() -> None:
-    snakeoil_path = Path(sys.argv[1])
-    CFG = ut.yaml_load(snakeoil_path / "fmuconfig/output/global_variables.yml")
+    project_path = Path(sys.argv[1])
+    CFG = ut.yaml_load(project_path / "fmuconfig/output/global_variables.yml")
     surf = xtgeo.surface_from_file(
-        snakeoil_path / "ert/output/maps/props/poro_average.gri"
+        project_path / "ert/output/maps/props/poro_average.gri"
     )
     dataio.ExportData(
         config=CFG,

tests/test_integration/conftest.py

@@ -86,7 +86,7 @@ def fmu_snakeoil_project(
         "STDERR EXPORT_A_SURFACE.stderr\n"
         "STDOUT EXPORT_A_SURFACE.stdout\n"
         "EXECUTABLE ../scripts/export-a-surface\n"
-        "ARGLIST <SNAKEOIL_PATH>\n",
+        "ARGLIST <PROJECT_PATH>\n",
         encoding="utf-8",
     )
 

tests/test_integration/ert_config_utils.py

@@ -3,8 +3,8 @@
 from pathlib import Path
 
 
-def add_create_case_workflow(filepath: Path | str) -> None:
-    with open(filepath, "a", encoding="utf-8") as f:
+def add_create_case_workflow(ert_config_path: Path | str) -> None:
+    with open(ert_config_path, "a", encoding="utf-8") as f:
         f.writelines(
             [
                 "LOAD_WORKFLOW ../bin/workflows/xhook_create_case_metadata\n"
@@ -13,8 +13,8 @@ def add_create_case_workflow(filepath: Path | str) -> None:
         )
 
 
-def add_copy_preprocessed_workflow(filepath: Path | str) -> None:
-    with open(filepath, "a", encoding="utf-8") as f:
+def add_copy_preprocessed_workflow(ert_config_path: Path | str) -> None:
+    with open(ert_config_path, "a", encoding="utf-8") as f:
         f.writelines(
             [
                 "LOAD_WORKFLOW ../bin/workflows/xhook_copy_preprocessed_data\n"
@@ -24,12 +24,12 @@ def add_copy_preprocessed_workflow(filepath: Path | str) -> None:
 
 
 def add_export_a_surface_forward_model(
-    snakeoil_path: Path, filepath: Path | str
+    project_path: Path, ert_config_path: Path | str
 ) -> None:
-    with open(filepath, "a", encoding="utf-8") as f:
+    with open(ert_config_path, "a", encoding="utf-8") as f:
         f.writelines(
             [
                 "INSTALL_JOB EXPORT_A_SURFACE ../bin/jobs/EXPORT_A_SURFACE\n"
-                f"FORWARD_MODEL EXPORT_A_SURFACE(<SNAKEOIL_PATH>={snakeoil_path})\n"
+                f"FORWARD_MODEL EXPORT_A_SURFACE(<PROJECT_PATH>={project_path})\n"
             ]
         )

tests/test_units/test_fmuprovider_class.py

@@ -410,9 +410,10 @@ def test_fmuprovider_workflow_reference(fmurun_w_casemetadata, globalconfig2):
 
 
 def test_ert_simulation_modes_one_to_one() -> None:
-    """Ensure dataio known modes match those defined by Ert. These are currently defined
-    in `ert.mode_definitions`. `MODULE_MODE` is skipped due to seemingly being relevant
-    to Ert internally -- the modes are duplicated there."""
+    """Ensure dataio known modes match those defined by Ert.
+
+    These are currently defined in `ert.mode_definitions`. `MODULE_MODE` is skipped due
+    to seemingly being relevant to Ert internally -- the modes are duplicated there."""
     ert_mode_definitions = importlib.import_module("ert.mode_definitions")
     ert_modes = {
         getattr(ert_mode_definitions, name)