Validate content value #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perolavsvendsen
requested review from
jcrivenaes,
HansKallekleiv,
anders-kiaer,
rwiker and
adnejacobsen
perolavsvendsen
commented
Sep 27, 2023
| @@ -61,6 +61,7 @@ def __post_init__(self): | |||
| "velocity": None, | |||
| "volumes": None, | |||
| "volumetrics": None, # or? | |||
| "inplace_volumes": None, # or? | |||
There was a problem hiding this comment.
Included to match the current examples, where this value is used for content.
adnejacobsen
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly solve #369
fmu-dataiocurrently allowsExportDatato be called withoutcontentexplicitly set. It will in those cases default to a generic value. However, we do not want those data to be available to any data consumer. Long-term, we will require that thecontentargument is used. Short-term (this PR), we will not validate documents with the default schema.This PR includes the whitelisted contents into the schema. It also introduces a test which fails if the list of contents in the code becomes out of synch with the list in the schema.