Remove table_index_values #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not used when table_index_values is removed
perolavsvendsen
approved these changes
Oct 3, 2023
|
Once (squashed and) merged, create a new release. Hopefully we can include it as a bugfix in Komodo latest. |
|
Also, if not done, suggest to test it out using e.g. komodo-env first to ensure it is compatible with whatever else is going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the table_index_values field from the metadata
Testing on large datasets like Snorre shows that the table_index_values is not sustainable.
There are also many problems with json serializability related to this field.