Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV: Set depth as default vertical_domain #807

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Sep 25, 2024

No description provided.

@@ -221,7 +221,7 @@ class ExportData:
Note also: If missing or empty, export() may still be done, but without a
metadata file (this feature may change in future releases).

content: Optional, default is "depth". Is a string or a dictionary with one key.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaked in a removal of incorrect documentation

@perolavsvendsen
Copy link
Member

Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests will pass, thanks for fast response 🚀

@mferrera
Copy link
Collaborator

Force merging this as the only failing test is due to a change in sumo uploader that broke create case metadata

@mferrera mferrera merged commit a28f1b3 into equinor:main Sep 25, 2024
9 of 13 checks passed
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants