Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webviz expects different name and tagname #101

Open
equinor-ruaj opened this issue Sep 25, 2024 · 8 comments
Open

Webviz expects different name and tagname #101

equinor-ruaj opened this issue Sep 25, 2024 · 8 comments
Assignees

Comments

@equinor-ruaj
Copy link
Contributor

equinor-ruaj commented Sep 25, 2024

Currently we set:
name based on filepath
tagname to "grid" or some "prefix"-"object name"

Webviz expects these to be:
name = parameter name
tagname = grid name
I.e. What today is name should be tagname and tagname should be name

@equinor-ruaj equinor-ruaj self-assigned this Sep 25, 2024
@equinor-ruaj
Copy link
Contributor Author

This is apparently not an issue for Webviz when equinor/fmu-dataio#803 is solved.

Should we also change name <-> tagname in Sim2sumo @perolavsvendsen?
Or should they be something different entirely to match other fmu data?

@perolavsvendsen
Copy link
Member

This relates to equinor/fmu-dataio#794 I think. Basically, there needs to be some sort of coherence between the different parts here. Currently, I think there has been a bit of siloed thinking on different components. This is particularly important for super-central metadata fields such as data.name and data.tagname which everyone is depending on for (almost) uniqueness.

Just to be clear, this is regarding 3D grid data - not timeseries/simulation output, yes?

I think it could makes some sense to use the parameter (name) as data.name, so that could be a good start. And it is probably OK to use the gridname for data.tagname. However this does not scale beyond 1 export of a specific grid, which I think we are well past already. (But ironically, due to lack of master data concepts, we probably call them different things during the same workflow, hence this has not hit.) (Yet.)

But OK, in lack of knowledge or better options right now, let's go with the suggestion from Webviz and see where that takes us.

@equinor-ruaj
Copy link
Contributor Author

Quickfix here

@perolavsvendsen
Copy link
Member

Is this something we could/should test in dev before it hits prod? Is that possible? Not fully sure about the consequences.

@equinor-ruaj
Copy link
Contributor Author

In the (not so distant) future we probably want to use fmu-dataio? #103

@equinor-ruaj
Copy link
Contributor Author

Is this something we could/should test in dev before it hits prod? Is that possible? Not fully sure about the consequences.

Which environment is targeted is up to users...
The change will only be available in Komodo bleeding, so stable users won't see any changes.

@perolavsvendsen
Copy link
Member

OK I'm thinking perhaps test this a bit in a branch or something before it hits Komodo

@equinor-ruaj
Copy link
Contributor Author

Tested in dev (see comment in PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants