Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap name and tagname for grids #104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

equinor-ruaj
Copy link
Contributor

Solves (?) #101

@equinor-ruaj
Copy link
Contributor Author

This probably also swaps name <-> tagname in file.relative_path...
Not sure if that breaks anything or will just "look weird" to users?

@rwiker
Copy link

rwiker commented Oct 3, 2024

The order in the filename should be the same as for other data types, I think.

@perolavsvendsen
Copy link
Member

Agree that there should be consistency across data types and contents. But we also know that there isn't necessarily full consistency in the currently used standard which this tries to emulate. So probably not possible to 100% win.

If possible, we could try to produce a case or two with this update to dev and have a look. I think the data browser in the Sumo front-end will quickly reveal if this is more, or less, chaos.

@equinor-ruaj equinor-ruaj force-pushed the change-name-and-tagname-for-grids branch from 2e7b72a to a3368aa Compare October 3, 2024 11:01
@equinor-ruaj
Copy link
Contributor Author

Separated metadata functions so "file.relative_path" should be set same as before. b8c05cf

@equinor-ruaj
Copy link
Contributor Author

Uploaded two Drogon cases to dev.
Left: Using this branch
Right: Using Sim2sumo main branch
image

name and tagname is swapped as intended.
file.relative_path is the same in both.
The rest of the metadata is also the same in both cases.

Other datatypes are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants