Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom deploy addon support cluster addon and can select version #6446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

feat custom deploy addon support cluster addon and can select version

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English feat custom deploy addon support cluster addon and can select version
🇨🇳 中文 自定义部署Addon支持集群级别Addon并且支持版本选择

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 46.73913% with 49 lines in your changes missing coverage. Please review.

Project coverage is 15.63%. Comparing base (f5acecb) to head (8b674b6).

Files with missing lines Patch % Lines
...nternal/tools/orchestrator/services/addon/addon.go 0.00% 34 Missing ⚠️
...tools/orchestrator/services/addon/addon_handler.go 57.14% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6446   +/-   ##
=======================================
  Coverage   15.62%   15.63%           
=======================================
  Files        3674     3674           
  Lines      311610   311671   +61     
=======================================
+ Hits        48679    48717   +38     
- Misses     257473   257494   +21     
- Partials     5458     5460    +2     
Flag Coverage Δ
by-github-actions 15.63% <46.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/tools/orchestrator/endpoints/addon.go 8.95% <100.00%> (+5.43%) ⬆️
...tools/orchestrator/services/addon/addon_handler.go 33.12% <57.14%> (-0.22%) ⬇️
...nternal/tools/orchestrator/services/addon/addon.go 14.39% <0.00%> (-0.15%) ⬇️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants