Switch docker push to be triggered on new release #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After test is successful, don't forget there are 3 places with username/reponame in that action. Just heads up ;-) |
reqlez
approved these changes
Sep 7, 2023
|
Based on this run here, it's now working properly: I changed it here to ergoplatform/oracle-core DockerHub repo now, that repo just needs to be created before we run this on release. @kushti heads up, and also set proper DOCKERHUB_USERNAME DOCKERHUB_TOKEN for ergoplatform account. Otherwise, LGTM after the above 2 tasks are complete. |
|
@reqlez Great job! Thank you very much! |
|
@kushti any luck setting this up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.