types: Update RLP encoding of EIP-6110 deposit reqs #12206
+34
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
added
the
do-not-merge
|
Keeping the structure mostly intact for now for deposit request, since it's decoded from the contract events, not directly from the contract itself. |
somnathb1
removed
the
do-not-merge
yperbasis
reviewed
Oct 11, 2024
| @@ -70,37 +68,42 @@ type DepositRequestJson struct { | |||
|
|
|||
| func (d *DepositRequest) RequestType() byte { return DepositRequestType } | |||
| func (d *DepositRequest) EncodeRLP(w io.Writer) (err error) { | |||
There was a problem hiding this comment.
EncodeRLP/DecodeRLP are no longer accurate because it's not RLP anymore.
There was a problem hiding this comment.
Yes, that's right. It was just following suite till now anyways and never was the full RLP encoding. This will be removed in subsequent PRs
There was a problem hiding this comment.
Furthermore, the RLP encoding of the flat version would be almost what it is here, and would still work with Engine API and block storage, hence leaving it for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref - ethereum/EIPs#8856
(Tasks board - #12106)
Just change RLP encoding function for deposit requests to a non-RLP flat encoding