Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesize method signature for dynamic property getters #223

Merged
merged 3 commits into from
Aug 22, 2015

Conversation

imhuntingwabbits
Copy link
Contributor

This PR adds the ability to synthesize the method signature for dynamic property getters which resolves this issue:

#215

There are a couple of issues I foresee:

  1. There are no sanity checks, i.e. this PR theoretically allows users to do things they can't today (like mocking CoreData objects) which could be considered evil.
  2. There are no checks for read-write / read only properties, so it may be necessary to add signatures for setters to this, but that is unclear to me.

@erikdoe erikdoe changed the title Issue 215 Synthesize method signature for dynamic property getters Aug 21, 2015
@erikdoe erikdoe merged commit 0b25b67 into erikdoe:master Aug 22, 2015
@imhuntingwabbits
Copy link
Contributor Author

Will do, I'll keep things separated in the future.

@erikdoe
Copy link
Owner

erikdoe commented Aug 27, 2015

@imhuntingwabbits Thanks. By the way, did you see #218?

@imhuntingwabbits imhuntingwabbits deleted the issue-215 branch September 15, 2015 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants