Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple protocol mocks #294

Closed
wants to merge 2 commits into from
Closed

Add support for multiple protocol mocks #294

wants to merge 2 commits into from

Conversation

mattrobmattrob
Copy link

@mattrobmattrob mattrobmattrob commented May 5, 2016 •
edited
Loading

  • Remove warnings in OCMockObjectRuntimeTests.m
  • Add tests in OCMockObjectProtocolMocksTests.m to test new multiple protocol mock
  • Add new macros to create multi-Protocol mocks with variadic methods

Completes #178.

@mattrobmattrob
Add support for multiple protocol mocks
908ba9d 
- Remove warnings in `OCMockObjectRuntimeTests.m`
- Add tests in `OCMockObjectProtocolMocksTests.m` to test new multiple protocol mock
- Add new macros to create multi-Protocol mocks

Completes erikdoe#178.
@mattrobmattrob
Copy link
Author

Executed 119 tests, with 0 failures (0 unexpected) in 1.884 (2.437) seconds

Not sure what's causing the Travis CI failure.

@mattrobmattrob
Copy link
Author

Investigating test failures in what seems to be the OCMockLib tests.

@mattrobmattrob mattrobmattrob reopened this May 6, 2016
@mattrobmattrob
Copy link
Author

mattrobmattrob commented May 6, 2016 •
edited
Loading

Test failures seem to be caused by va_arg(...) behaving badly when compiled originally for a 64-bit system and then used on a 32-bit system. Not sure if this is a show stopper or not or would be fixed when you ship a new version of the library.

@mattrobmattrob
Update _variadicArgumentsToArray:args: method
fd8cde6 
Update method to have better pre-ARC memory management syntax (I think).
@mattrobmattrob mattrobmattrob force-pushed the mr/add.multi.protocol.support branch from 5c10ac3 to fd8cde6 Compare May 6, 2016 21:32
@erikdoe
Copy link
Owner

erikdoe commented Dec 13, 2016

This seems to have been superseded by #309. That does have some issues, but this PR also seems to be incomplete at this stage. So, I'm going to close it assuming that we'll get #309 working.

@erikdoe erikdoe closed this Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattrobmattrob @erikdoe