Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project settings to latest xcode and fix warnings #366

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

imhuntingwabbits
Copy link
Contributor

Xcode wanted to enable CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS. I let it and there was some minor fallout in the tests.

@ian-twilightcoder
Copy link
Contributor

Same thing as #364?

@imhuntingwabbits
Copy link
Contributor Author

Same thing as #364?

A slightly more discrete subset, although I do think 364 makes some valuable additions.

@erikdoe erikdoe merged commit c4fe6e4 into erikdoe:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants